Skip to content

Add AOT publish test job#7302

Draft
Nigusu-Allehu wants to merge 4 commits intodev-feature-nsj-stj-migrationfrom
dev-nyenework-aot-publish-job
Draft

Add AOT publish test job#7302
Nigusu-Allehu wants to merge 4 commits intodev-feature-nsj-stj-migrationfrom
dev-nyenework-aot-publish-job

Conversation

@Nigusu-Allehu
Copy link
Copy Markdown
Member

@Nigusu-Allehu Nigusu-Allehu commented Apr 19, 2026

Bug

Fixes: NuGet/Home#14847

Description

Adds a CI check that catches Native AOT regressions in NuGet.Core libraries on every PR.

  • test/NuGet.AotCompatibility.Test/ - minimal app referencing all 12 AOT-eligible NuGet.Core libraries via
    TrimmerRootAssembly, with IlcTreatWarningsAsErrors=true. Not added to the solution.
  • New AOT Compatibility stage in pr.yml runs dotnet publish -r win-x64 on Windows.

Note: This new job is expected to fail until the migration is complete.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@Nigusu-Allehu Nigusu-Allehu changed the title Add AOT publisj test job Add AOT publish test job Apr 19, 2026
@Nigusu-Allehu Nigusu-Allehu force-pushed the dev-nyenework-aot-publish-job branch from e31f04e to 7b72586 Compare April 20, 2026 16:33
@Nigusu-Allehu Nigusu-Allehu self-assigned this Apr 20, 2026
@Nigusu-Allehu Nigusu-Allehu marked this pull request as ready for review April 20, 2026 16:43
@Nigusu-Allehu Nigusu-Allehu requested a review from a team as a code owner April 20, 2026 16:43
@Nigusu-Allehu Nigusu-Allehu requested review from kartheekp-ms and nkolev92 and removed request for a team April 20, 2026 16:43
@@ -0,0 +1,40 @@
<Project Sdk="Microsoft.NET.Sdk">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New project in the repo, should it be added to NuGet.sln and some of the slnf files?

Before we started running CI on dnceng-public, I had a script in our pipeline to make sure that all csproj files on disk were also in the sln. But it looks like it was lost during the migration.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentionally left out. It is a standalone smoke-test executable it exists only to verify that the NuGetCore AOT compilation works. It has no library consumers and is not part of the normal build or test. Adding it to the solution would pull it into every build without any benefit. Please let me know if there is a reason, we want it there?

@Nigusu-Allehu Nigusu-Allehu requested a review from zivkan April 20, 2026 20:56
@jeffkl jeffkl marked this pull request as draft April 21, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants